Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for SSNv2 #4886

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Add tests for SSNv2 #4886

merged 1 commit into from
Oct 28, 2024

Conversation

edewata
Copy link
Contributor

@edewata edewata commented Oct 26, 2024

New tests have been added to verify a single CA and CA clones with SSNv2. New test scripts for SSNv2 have also been added to make it easier to change the location of the range objects and nextRange attributes later.

The test for CA with Nuxwdog has been relocated due to GitHub workflow limit.

New tests have been added to verify a single CA and CA clones
with SSNv2. New test scripts for SSNv2 have also been added to
make it easier to change the location of the range objects and
nextRange attributes later.

The test for CA with Nuxwdog has been relocated due to GitHub
workflow limit.
Copy link

Copy link
Member

@fmarco76 fmarco76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

there is no need to duplicate the scripts in tests/ca/bin but they need to read the correct tree. We can improve this after the other PR to make them more configurable.

@edewata
Copy link
Contributor Author

edewata commented Oct 28, 2024

LGTM

there is no need to duplicate the scripts in tests/ca/bin but they need to read the correct tree. We can improve this after the other PR to make them more configurable.

@fmarco76 Thanks!

I agree. Maybe we should just use an option like -t <type> to keep it simple and the script will generate the proper DN for that generator type?

@edewata edewata merged commit 6026ef0 into dogtagpki:master Oct 28, 2024
160 of 168 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants